> On Mon, 21 Jan 2008 22:02:15 -0500 "Theodore Ts'o" <tytso@xxxxxxx> wrote: > The below patch add ioctl for migrating ext3 indirect block mapped inode > to ext4 extent mapped inode. This patch adds lots of weird and inexplicable single- and double-newlines in inappropriate places. However it frequently forgets to add newlines between end-of-locals and start-of-code, which is usual practice. +struct list_blocks_struct { + ext4_lblk_t first_block, last_block; + ext4_fsblk_t first_pblock, last_pblock; +}; This structure would benefit from some code comments. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html