On Wed, 2007-10-10 at 15:00 -0400, Theodore Tso wrote: > On Wed, Oct 10, 2007 at 08:30:10AM -0700, Badari Pulavarty wrote: > > Its a good start. I think there are lots of proc handling routines that > > can be move into #ifdef CONFIG_PROC_FS also. > > > > All the code around ext4_mb_read_prealloc_table(), > > ext4_mb_write_prealloc_table(), MB_PROC_VALUE_READ(stats), > > MB_PROC_VALUE_WRITE(stats), .. can be ifdefed out. > > There's no need to ifdef them out; in include/proc_fs.h there are the > following convenience #define's if CONFIG_PROC_FS is not defined: Sorry. If I wasn't clear.. What I meant to say was the above routines are NOT needed if we don't define CONFIG_PROC_FS. They are supporting read/write to /proc files. We can #ifdef them out to reduce the text size. Thanks, Badari - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
