On Tue, Oct 09, 2007 at 10:03:06AM -0700, Mingming Cao wrote: > I guess our testing did not catch this up because we have CONFIG_PROC_FS > enabled all the time. mballoc needs procfs for exporting some stats info > and tunable paramenters to optimize/customize multiple allocation. > > We could select CONFIG_PROC_FS at kconfig when ext4dev is enabled. We definitely should be able to compile without CONFIG_PROC_FS; it's a major flaw in the mballoc-core.patch that it doesn't work without it. I'm not sure why ext4_pspace_cachep is initialized in init_ext4_proc(), since it looks like that is being used as part of the core mballoc infrastructure, and just for proc work. It's definitely very unfortunate that the proc support is intertwined with the rest of the mballoc code, since the it means that adding the straight-forward #ifdef's will make the code quite ugly. - Ted - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
