On Aug 28, 2007 15:29 -0500, Eric Sandeen wrote: > Andreas Dilger wrote: > >> (there are 54 BUGs and BUG_ONs in this file...!) > > > > Yes, we like lots of assertions in our code, because it is exceedingly > > complex to debug otherwise. > > But wouldn't error recovery be a better choice? You could macro-ize it > to BUG for development purposes if you wanted, I suppose... No, the goal is if something "impossible" happens you want to stop dead at that point instead of continuing to work in an unknown environment. I believe that all of the extents/mballoc code will NOT BUG on bad data from disk. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
