[PATCH] fix mballoc oopses on mkdir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tried out Ted's git tree + all pending patches today, and 
immediately oopsed on a mkdir thanks to this in 
ext4_mb_new_group_pa()

	BUG_ON(!S_ISREG(ac->ac_inode->i_mode));

(there are 54 BUGs and BUG_ONs in this file...!)

I think something like this patch is needed?

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Index: ext4.git/fs/ext4/extents.c
===================================================================
--- ext4.git.orig/fs/ext4/extents.c
+++ ext4.git/fs/ext4/extents.c
@@ -2535,7 +2537,8 @@ int ext4_ext_get_blocks(handle_t *handle
 	ar.goal = ext4_ext_find_goal(inode, path, iblock);
 	ar.logical = iblock;
 	ar.len = allocated;
-	ar.flags = EXT4_MB_HINT_DATA;
+	if (S_ISREG(inode->i_mode))
+		ar.flags = EXT4_MB_HINT_DATA;
 	newblock = ext4_mb_new_blocks(handle, &ar, &err);
 	if (!newblock)
 		goto out2;

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux