On Tue, 2007-07-17 at 15:29 +0530, Kalpak Shah wrote: > On Mon, 2007-07-16 at 17:49 -0700, Mingming Cao wrote: > > On Tue, 2007-07-10 at 16:30 -0700, Andrew Morton wrote: > > > On Sun, 01 Jul 2007 03:36:56 -0400 > > > Mingming Cao <cmm@xxxxxxxxxx> wrote: > > > > +static inline __le32 ext4_encode_extra_time(struct timespec *time) > > > > +{ > > > > + return cpu_to_le32((sizeof(time->tv_sec) > 4 ? > > > > + time->tv_sec >> 32 : 0) | > > > > + ((time->tv_nsec << 2) & EXT4_NSEC_MASK)); > > > > +} > > > > + > > > > +static inline void ext4_decode_extra_time(struct timespec *time, __le32 extra) > > > > +{ > > > > + if (sizeof(time->tv_sec) > 4) > > > > + time->tv_sec |= (__u64)(le32_to_cpu(extra) & EXT4_EPOCH_MASK) > > > > + << 32; > > > > + time->tv_nsec = (le32_to_cpu(extra) & EXT4_NSEC_MASK) >> 2; > > > > +} > > > > > > Consider uninlining these functions. > > > > > I got compile warining after apply Kalpal's update nanosecond patch, > > which makes these two function inline. It complains these functions are > > defined but not used. It's being used only in the following > > micros(EXT4_INODE_SET_XTIME etc). So if the .c file included the > > ext4_fs.h but not using the micros, the compile will think these two > > functions are not used. > > The compile warnings were introduced because the functions were > uninlined. So we can either keep these functions inlined or consider > adding a "__used" attribute to these two functions. > okay for now I keep these functions inlined. > Thanks, > Kalpak. > - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html