Re: e2fsprogs coverity patch <cid-05.diff>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 09, 2007 at 06:11:41PM -0800, Brian D. Behlendorf wrote:
> array is initially set to NULL, so it is possible that readdir() will return
> NULL and leave array set to NULL. Thus we do need to check if array is NULL or
> check if num != 0.
> 
> Coverity ID: 5: Forward NULL

This wasn't the only bug; it turns out that if /etc/e2fsck.conf or
/etc/mke2fs.conf is an empty directory, then your patch would fix this
segfault, only for it to segfault later in profile_init().  I'll fix
this before I commit.

					- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux