Lawrence Livermore National Labs recently ran the source code analysis tool Coverity over the e2fsprogs-1.39 source to see if it would identify any significant bugs. The analysis turned up 38 mostly minor issues which are enumerated here with patches. We went through and resolved these issues but would love to see these mostly minor changes reviewed and commited upstream. Thanks, Brian Behlendorf <behlendorf1@xxxxxxxx>, and Herb Wartens <wartens2@xxxxxxxx> ----------------------------------------------------------------------------- Coverity ID: 5: Forward NULL array is initially set to NULL, so it is possible that readdir() will return NULL and leave array set to NULL. Thus we do need to check if array is NULL or check if num != 0. There is definitely space allocated to array in the normal case. It calls realloc which since array is NULL the first time through will behave like malloc. The other times we will resize the array to be 11 larger. It should be safe to run qsort on array since num should be set to 0 so nothing will be sorted. It should also be safe to set *ret_array = array. The array passed in should just be NULL at this point. Index: e2fsprogs+chaos/e2fsck/profile.c =================================================================== --- e2fsprogs+chaos.orig/e2fsck/profile.c +++ e2fsprogs+chaos/e2fsck/profile.c @@ -280,7 +280,8 @@ static errcode_t get_dirlist(const char array[num++] = fn; } qsort(array, num, sizeof(char *), compstr); - array[num++] = 0; + if(array) + array[num++] = 0; *ret_array = array; closedir(dir); return 0; - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
