Alex Tomas wrote:
Mingming Cao (MC) writes:
MC> But the bug Amit pointed here is unrelated to the code convert
MC> uninitialized blocks to initialized ones. Rather, it's related to do
MC> multiple block allocation across on a window with parts already have
MC> blocks allocated. Without the check, the current code just simply
MC> allocate the requested extent and insert it into the tree which might
MC> overlap with existing extent.
correct. thanks for catching. in delayed allocation patch
get_blocks() isn't used and ext4_ext_walk_space() works
right in this case.
Yep, I realized that yesterday. That explains we never see this overlap
problem when we testing extent+delalloc+mballoc last year.
ext4_ext_walk_space did almost all the overlap check. I think we
could reuse that code.
Mingming
thanks, Alex
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
