>>>>> Amit K Arora (AKA) writes: AKA> The ext4_ext_get_blocks() and ext4_ext_insert_extent() routines do not AKA> check for extent overlap, when a new extent needs to be inserted in an AKA> inode. An overlap is possible when the new extent being inserted has AKA> ee_block that is not part of any of the existing extents, but the AKA> tail/center portion of this new extent _is_. This is possible only when AKA> we are writing/preallocating blocks across a hole. not sure I understand ... you shouldn't insert an extent that overlap any existing extent. when you write block(s), you first check is it already allocated and insert new extent only if it's not. for preallocated block(s), you should adapt existing extent(s) so that they don't overlap new extent you're inserting. am I missing something? also, I think that modification of existing extent(s) (not merging) isn't safe. thanks, Alex - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
