Re: [RFC PATCH net-next 2/5] net: dsa: propagate flags down towards drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023-01-19 00:01, Vladimir Oltean wrote:
On Wed, Jan 18, 2023 at 11:35:08PM +0100, netdev@xxxxxxxxxxxxxxxxxxxx wrote:

When the new dynamic flag is true, all drivers will ignore it in patch #3,
so basically nothing will change by that.

This is not true, because it assumes that DSA never called port_fdb_add()
up until now for bridge FDB entries with the BR_FDB_STATIC flag unset,
which is incorrect (it did).

So what will change is that drivers which used to react to those bridge
FDB entries will stop doing so.


So the solution to this problem could be to only set the is_dyn flag in combination with the added_by_user flag. So an 'and' operation with the two in br_switchdev_fdb_populate()?



[Index of Archives]     [Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux