On Thu, Feb 24, 2022 at 08:48, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > On Thu, 24 Feb 2022 17:29:35 +0100 Joachim Wiberg wrote: >> On Thu, Feb 24, 2022 at 08:06, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: >> > On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote: >> >> On 23/02/2022 19:24, Joachim Wiberg wrote: >> [...] >> >> It would be nice to add a selftest for L2 entries. You can send it as a follow-up. >> > Let's wait for that, also checkpatch says you need to balance brackets >> > to hold kernel coding style. >> Jakub, by "wait for that" do you mean you'd prefer I add the selftests >> to this? > Yes, add a selftest as a separate patch but in the same series. OK, will do, thanks! :) Regards /Joachim