Re: [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote:
> On 23/02/2022 19:24, Joachim Wiberg wrote:
> > This patch expands on the earlier work on layer-2 mdb entries by adding
> > support for host entries.  Due to the fact that host joined entries do
> > not have any flag field, we infer the permanent flag when reporting the
> > entries to userspace, which otherwise would be listed as 'temp'.
> > 
> > Before patch:
> > 
> >     ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee permanent
> >     Error: bridge: Flags are not allowed for host groups.
> >     ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee
> >     Error: bridge: Only permanent L2 entries allowed.
> > 
> > After patch:
> > 
> >     ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee permanent
> >     ~# bridge mdb show
> >     dev br0 port br0 grp 01:00:00:c0:ff:ee permanent vid 1
> > 
> > Signed-off-by: Joachim Wiberg <troglobit@xxxxxxxxx>
>
> It would be nice to add a selftest for L2 entries. You can send it as a follow-up.

Let's wait for that, also checkpatch says you need to balance brackets
to hold kernel coding style.

> Acked-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>



[Index of Archives]     [Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux