On 5/18/17 6:53 PM, Vivien Didelot wrote:
Hi Nikolay,
Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx> writes:
+ int msgtype = nlh->nlmsg_type;
minor nits:
nlmsg_type is a u16, also please keep the order and arrange these from longest
to shortest
The reverse christmas tree \o/
Hum, __br_mdb_notify takes an int type, and struct nlmsghdr defines it
as a __u16. Does u16 still make sense here instead of int?
Thanks,
Vivien
Either way is fine as long as the value is unchanged, and since the rest of
the code uses an int then lets be consistent and leave it or if you decide
change all.
Cheers,
Nik
