Re: [SPAM]Re: [PATCH net-next 5/6] net: bridge: get msgtype from nlmsghdr in mdb ops

[Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx>]

Hi Nikolay,

Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx> writes:

>> +	int msgtype = nlh->nlmsg_type;
>
> minor nits:
> nlmsg_type is a u16, also please keep the order and arrange these from longest 
> to shortest

The reverse christmas tree \o/

Hum, __br_mdb_notify takes an int type, and struct nlmsghdr defines it
as a __u16. Does u16 still make sense here instead of int?


Thanks,

        Vivien