On 04/08/2016 06:03 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change internally or from > sysfs/ioctl, that a netlink notification is sent out to listeners. > > Also, NetworkManager will use this in the future to listen for out-of-band > bridge master attribute updates and incorporate them into the runtime > configuration. > > This patch is used for br_sysfs_if, and we also move br_ifinfo_notify out > of store_flag. > > Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx> > --- > net/bridge/br_sysfs_if.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Note: there's a slight behaviour change, before if the flags were the same a notification wouldn't be sent, now it would. Anyway I don't see a problem as this is true for other attributes which are set to the same value. Reviewed-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>
