On 04/08/2016 06:03 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change internally or from > sysfs/ioctl, that a netlink notification is sent out to listeners. > > Also, NetworkManager will use this in the future to listen for out-of-band > bridge master attribute updates and incorporate them into the runtime > configuration. > > This patch is used for br_sysfs_br. and we also need to remove some > rtnl_trylock in old functions so that we can call it in a common one. > > For group_addr_store, we cannot make it use store_bridge_parm, because > it's not a string-to-long convert, we will add notification on it > individually. > > Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx> > --- > net/bridge/br_sysfs_br.c | 21 +++++++++------------ > net/bridge/br_vlan.c | 30 +++++------------------------- > 2 files changed, 14 insertions(+), 37 deletions(-) > Signed-off-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>