On Mon, Mar 10, 2014 at 11:56:00PM +0100, Hannes Frederic Sowa wrote:
> On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote:
> > br_multicast_query_received(br, port, &br->ip6_querier,
> > - !ipv6_addr_any(&ip6h->saddr), max_delay);
> > + !ipv6_addr_any(&ip6h->saddr),
> > + is_general_query, max_delay);
>
> Just a small nit, maybe for a later patch:
>
> After your change 6565b9eeef194a ("bridge: multicast: add sanity check
> for query source addresses"), which is still in -net only, we could
> replace !ipv6_addr_any(&ip6h->saddr) with '1'?
Aiy, good point, that part is obsolete now and
br_multicast_query_received() could be simplified, right. Going
to do that once we are out of deep-RC territory again and/or
the according commit is available in net-next. Thanks for the
hint!
Cheers, Linus
Attachment:
signature.asc
Description: Digital signature
