On Mon, Mar 10, 2014 at 10:25:25PM +0100, Linus Lüssing wrote: > br_multicast_query_received(br, port, &br->ip6_querier, > - !ipv6_addr_any(&ip6h->saddr), max_delay); > + !ipv6_addr_any(&ip6h->saddr), > + is_general_query, max_delay); Just a small nit, maybe for a later patch: After your change 6565b9eeef194a ("bridge: multicast: add sanity check for query source addresses"), which is still in -net only, we could replace !ipv6_addr_any(&ip6h->saddr) with '1'? Greetings, Hannes