Thanks. I'll post an updated patch. On Fri, 2009-11-27 at 14:09 +0100, Arnd Bergmann wrote: > On Friday 13 November 2009, Patrick Mullaney wrote: > > @@ -551,7 +532,7 @@ static int macvlan_newlink(struct net_device *dev, > > return err; > > > > list_add_tail(&vlan->list, &port->vlans); > > - macvlan_transfer_operstate(dev); > > + netif_stacked_transfer_operstate(dev, lowerdev); > > return 0; > > } > > > > @@ -591,7 +572,8 @@ static int macvlan_device_event(struct notifier_block *unused, > > switch (event) { > > case NETDEV_CHANGE: > > list_for_each_entry(vlan, &port->vlans, list) > > - macvlan_transfer_operstate(vlan->dev); > > + netif_stacked_transfer_operstate(vlan->dev, > > + vlan->lowerdev); > > break; > > case NETDEV_FEAT_CHANGE: > > list_for_each_entry(vlan, &port->vlans, list) { > > These have the arguments reversed, lowerdev should come first. > > Arnd <>< _______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/bridge