[PATCH] rstpd: sizeof mismatch for some setups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch is against rstpd v.0.21 (get it here: 
https://lists.linux-foundation.org/pipermail/bridge/2009-February/006178.html).
BTW, it seems there are 2 rstpd forks, one is v.0.21 and is maintained by 
Srinivas, while the other uses rstplib, is v.0.16 and is maintained by 
Stephen (here: 
http://git.kernel.org/?p=linux/kernel/git/shemminger/rstp.git;a=summary)
I am pretty confused with this divergence, which should one use to start from? 
(personally I selected Srinivas' version as it seems to be more up-to-date).

Description:
For some setups (e.g. mine) sizeof(STP_MacAddress) != 6, which causes compiler 
error (thanks to the CMP macro, it's really useful)

Signed-off-by: Vitaly Demyanec <vitas at nppfactor.kiev.ua>
---

--- a/rstp.c	2009-05-21 13:01:09.000000000 +0300
+++ b/rstp.c	2009-05-21 13:06:08.000000000 +0300
@@ -2600,9 +2600,9 @@
   }
 
   if (cfg->set_bridge_address &&
-      CMP(BridgeIdentifier.bridge_address, !=, cfg->bridge_address)) {
+      CMP(BridgeIdentifier.bridge_address, !=, cfg->bridge_address.addr)) {
 
-    CPY(BridgeIdentifier.bridge_address, cfg->bridge_address);
+    CPY(BridgeIdentifier.bridge_address, cfg->bridge_address.addr);
 
     changed = TRUE;
     init = TRUE;

-- 
With Best Regards,
Vitaly Demyanec
Head engineer
Factor-SPE
Kiev, Ukraine
tel/fax: +380(44)249-21-63
_______________________________________________
Bridge mailing list
Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/bridge

[Index of Archives]     [Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux