On 28 Feb 2011, at 19:23, Sam Ravnborg wrote: > You are using /proc/* to something that is not process related. > At lkml you will be requested to use something else. OK. That's mainly through ignorance of what I *should* be using instead (and perhaps poor reading of Linux Device Drivers). Do you have an opinion on where such information should be going? > You can conisder splitting this up in another file so you > in the Makefile can use it conditionally. That makes sense. >> If there is a better way for me to submit this, please let me know. > > One way you would not like.... > Let the first patches introduce core-functionality and add features > in later patches - touching the same file many times. Hmm. That's very sensible. Assuming I can figure out a sensible way to do it (which I assume is what you expected me to object). It would certainly be interesting to do (sort of reverse archaeology), but would take a while, and it would, of course, also mean rewriting all of my tests to only test whatever is still there (I'm assuming a source file is only interesting if it actually *works*). It would, of course, also have the advantage of presenting the "simplest possible" idea of KBUS, followed by "but it appears also to be necessary to do this" patches. Which is presumably why you suggest it. > Also please submit the Makefile/Kconfig stuff in the _last_ mail. > Otherwise you would ruin bisect because we cannot build kbus until > you have the last files included. Ah. Not something I have experience of. I shall make it so. Thank you, Tibs -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
