Re: [RFC/PATCH 0/2] u_char.c and mtp.c patches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 19, 2010 at 08:57:18PM +0200, ext Michał Nazarewicz wrote:
On Mon, Apr 19, 2010 at 06:55:53PM +0200, Michał Nazarewicz wrote:
On related news, I've just posted FunctionFS driver. :) It's still imperfect
but appears to be working.

On Mon, Apr 19, 2010 at 07:15:34PM +0200, ext Greg KH wrote:
Yes, that should solve the gadgetfs issue for you, right Felipe?

On Mon, 19 Apr 2010 19:24:04 +0200, Felipe Balbi <felipe.balbi@xxxxxxxxx> wrote:
sure it should. Will take a look at it :-)

As I've said it's still imperfect.  In particular the throughput won't be
impressive but that's on the TODO list (I first want to put a real driver

yeah, I saw that you allocate the memory whenever you get read()/write(). That's a good choice IMO. It would be nice if you would have a vmalloc()ed kfifo instead and use that a ring buffer. Then you unload in smaller chunks.

on top of FunctionFS before optimising the code) and in particular u_char
seem to be a good piece to steal code from. ;)  Still, as said, I haven't
analysed possible optimisations just yet.

go for it :-)

It's free software anyways :-D

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Gstreamer Embedded]     [Linux MMC Devel]     [U-Boot V2]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux ARM Kernel]     [Linux OMAP]     [Linux SCSI]

  Powered by Linux