On Wed, Nov 5, 2008 at 1:57 AM, Paulius Zaleckas <paulius.zaleckas@xxxxxxxxxxxx> wrote: > Mike Frysinger wrote: >> On Wed, Nov 5, 2008 at 03:11, David Brownell wrote: >>> On Tuesday 04 November 2008, Mike Frysinger wrote: >>>>> If indeed OF functions don't have declarations which are >>>>> available on all platforms, that might be worth fixing >>>>> to enable this approach to #ifdef elimination. >>>> OF is open firmware right ? no way there's going to be OF for every >>>> port that supports GPIO, so filling out the stubs in linux/of_gpio.h >>>> will need to be done. >>> In which case the boolean "we don't have OF" would be "false" and >>> any code referencing the declared functions would be compiled out >>> (being dead code/data). So there would be no link-time references >>> to any OF routines... standard technique. >> >> i understand the compiler side just fine. my point is that the >> current linux/of_gpio.h only defines the OF structure and related >> prototypes when CONFIG_OF_GPIO is defined. so it needs updating >> first. > > This is small problem compared to what you will find in linux/of_device.h > It includes <asm/of_device.h> which contains main of_device structure > and this won't work with any non OF platform. Maybe the best solution is > to write separate driver for OF which will be just wrapper for platform > driver... Just like you suggested. More complex than necessary. Just give the driver 2 blocks of binding code; one for OF, one for non-OF. No need to split up the driver. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
