On Tue, Nov 4, 2008 at 23:45, David Brownell wrote: > On Tuesday 04 November 2008, Mike Frysinger wrote: >> > That's generally the preferred way to handle #ifdeffery. >> > But I could imagine OF isn't (yet?) set up to handle it. >> >> i agree completely with the inclination to do it all in C as you've >> suggested and let the compiler do dead code elimination, but that only >> works if the functions in question are defined everywhere (in other >> words, there's a linux/ api for it). i dont think that's the case for >> OF (which is what you were implying?) ... > > Only works if the functions are "declared" everywhere; > the stuff that's included in header files. > > A "definition" would be available at link time (except > for inlined functions, in headers). Actual C functions. > > If indeed OF functions don't have declarations which are > available on all platforms, that might be worth fixing > to enable this approach to #ifdef elimination. OF is open firmware right ? no way there's going to be OF for every port that supports GPIO, so filling out the stubs in linux/of_gpio.h will need to be done. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-embedded" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html