On Tue, Feb 11, 2025 at 04:05:12PM +0000, Aditya Garg wrote: > > On 11 Feb 2025, at 1:28AM, Lukas Wunner <lukas@xxxxxxxxx> wrote: > > FWIW, below would be my suggestion for replacing the DMI-based quirk > > with one that is based on the number of GPUs. > > > > It should invoke the apple_set_os protocol both on dual GPU laptops > > as well as ones with an eGPU, hence my expectation is that it should > > fix the issue reported by Lleyton. > > This patch does not enable the os set protocol on my MacBook Pro 16 inch 2019 > > journalctl -k: https://pastebin.com/7etWy0D5 Hm, perhaps Apple's EFI disables the iGPU by default and re-enables it upon the set_os protocol call. Or I've botched the patch, but I just double-checked the logic and it seems fine to me. Could somebody with an eGPU test whether the patch results in the expected invocation of set_os (and thus a working eGPU)? If it does, we'd just have to keep apple_match_product_name() as an alternative condition under which set_os is called. Thanks, Lukas
