On Sun, Dec 29, 2024 at 11:08:55AM +0100, Ard Biesheuvel wrote: > IIRC, the original issue is about not being able to use the discrete > GPU with the built-in panel, and the issue about an external GPU did > come up in the discussion - however, this does not affect the built-in > panel at all. The original issue was that the integrated GPU is hidden (powered off) unless the set_os protocol is used. So only the discrete GPU is available, which results in terrible battery life. Using set_os keeps the iGPU exposed so the OS can switch to it and power off the dGPU. We could have solved this by checking whether there are two PCI devices with VGA class in the system. But that would have triggered in the iGPU + eGPU case. We wanted to avoid that and thus quirked for the DMI product names instead. Thanks, Lukas
