On 14.04.23 12:48:05, Jonathan Cameron wrote: > On Thu, 13 Apr 2023 14:40:10 -0500 > Terry Bowman <Terry.Bowman@xxxxxxx> wrote: > > > Hi Jonathan, > > > > On 4/13/23 11:08, Jonathan Cameron wrote: > > > On Tue, 11 Apr 2023 13:02:58 -0500 > > > Terry Bowman <terry.bowman@xxxxxxx> wrote: > > > > > >> The CXL driver plans to use cper_print_aer() for restricted CXL host (RCH) > > >> logging. This is not currently possible if CXL is built as a loadable > > >> module because cper_print_aer() depends on cper_mem_err_unpack() which > > >> is not exported. > > >> > > >> Export cper_mem_err_unpack() to enable cper_print_aer() usage in > > >> CXL and other loadable modules. > > > > > > No problem with the export, but I'm struggling to see the path that needs it. > > > Could you give a little more detail, perhaps a call path? > > > > > > > The cper_print_aer() is used to log RCH dport AER errors. This is needed > > because the RCH dport AER errors are not handled directly by the AER port > > driver. I'll add these details to the patch. > > Ah. I wasn't particularly clear. cper_print_aer() is fine, but oddly > I'm not seeing where that results in a call to cper_mem_err_unpack() > > More than possible my grep skills are failing me! No worries, it is used in some odd tracepoint macro magic included with ras_event.h. -Robert
