On Tue, 11 Apr 2023 13:02:58 -0500 Terry Bowman <terry.bowman@xxxxxxx> wrote: > The CXL driver plans to use cper_print_aer() for restricted CXL host (RCH) > logging. This is not currently possible if CXL is built as a loadable > module because cper_print_aer() depends on cper_mem_err_unpack() which > is not exported. > > Export cper_mem_err_unpack() to enable cper_print_aer() usage in > CXL and other loadable modules. No problem with the export, but I'm struggling to see the path that needs it. Could you give a little more detail, perhaps a call path? Thanks, Jonathan > > Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > Cc: Ard Biesheuvel <ardb@xxxxxxxxxx> > Cc: linux-efi@xxxxxxxxxxxxxxx > --- > drivers/firmware/efi/cper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c > index 35c37f667781..ff15e12160ae 100644 > --- a/drivers/firmware/efi/cper.c > +++ b/drivers/firmware/efi/cper.c > @@ -350,6 +350,7 @@ const char *cper_mem_err_unpack(struct trace_seq *p, > > return ret; > } > +EXPORT_SYMBOL_GPL(cper_mem_err_unpack); > > static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem, > int len)
