On Sun, 24 Jul 2022 at 19:28, Borislav Petkov <bp@xxxxxxx> wrote: > > On Sun, Jul 24, 2022 at 10:39:45AM +0200, Ard Biesheuvel wrote: > > Fair enough. I still think it is better for general hygiene to apply > > these changes, but if there is no urgency, I'll leave this for now and > > revisit+rebase somewhere during the next cycle. > > Best it would be if you do that early in the cycle so that it gets > maximum testing in linux-next. > Sure > Oh, and my compiler doesn't like it for whatever reason: > > /tmp/ccLB2vIC.s: Assembler messages: > /tmp/ccLB2vIC.s: Error: invalid operands (.rodata and .text sections) for `-' when setting `.L__sym_size___efi64_thunk' > make[3]: *** [scripts/Makefile.build:322: arch/x86/platform/efi/efi_thunk_64.o] Error 1 > make[3]: *** Waiting for unfinished jobs.... > Are you sure you fixed up the conflict correctly? It seems the __efi64_thunk end marker ends up in .rodata in your case. > But otherwise, I like the direction where this is going, of us not > mapping as much into the EFI PGT. But I've said that already... > Yes. I'll update the patch to unmap text and rodata entirely, and only leave the trampoline mapped.
