On 07.12.21 21:20:25, Shuai Xue wrote: > >> --- a/include/linux/cper.h > >> +++ b/include/linux/cper.h > >> @@ -568,7 +568,8 @@ void cper_print_proc_arm(const char *pfx, > >> const struct cper_sec_proc_arm *proc); > >> void cper_print_proc_ia(const char *pfx, > >> const struct cper_sec_proc_ia *proc); > >> -int cper_mem_err_location(struct cper_mem_err_compact *mem, char *msg); > >> -int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg); > >> +int cper_mem_err_location(const struct cper_mem_err_compact *mem, char *msg); > >> +int cper_dimm_err_location(const struct cper_mem_err_compact *mem, char *msg); > > > > Do we really need that 'const' here? > I think we do. It is read only and should not be modified in these functions, > just as cper_print_proc_arm' style. Even if it is used read-only I don't see a real need for const here. So let's change this only if there is a reason such as avoiding unnecessary casts. > >> +const char *cper_mem_err_status_str(u64 status); > > > > The function i/f is different compared to the others, though the > > purpose is the same. Let's use same style: > > > > int cper_mem_err_status(const struct cper_mem_err_compact *mem, char *msg); > Sorry, I don't catch it. cper_mem_err_status_str() decodes the error status and return > a string, the same style as cper_severity_str and cper_mem_err_type_str do. May > we need to move the declaration ahead with cper_severity_str? Right, move it after cper_mem_err_type_str(). Looks good then. Thanks, -Robert
