Hi Geert, On Thu, Oct 10, 2019 at 08:50:45PM +0200, Geert Uytterhoeven wrote: [...] > > > > drivers/firmware/efi/Kconfig | 5 ++++- > > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig > > > > index 178ee8106828..6e4c46e8a954 100644 > > > > --- a/drivers/firmware/efi/Kconfig > > > > +++ b/drivers/firmware/efi/Kconfig > > > > @@ -181,7 +181,10 @@ config RESET_ATTACK_MITIGATION > > > > reboots. > > > > > > > > config EFI_RCI2_TABLE > > > > - bool "EFI Runtime Configuration Interface Table Version 2 Support" > > > > + bool > > > > + prompt "EFI RCI Table Version 2 Support" if X86 || COMPILE_TEST > > Why the split of bool and prompt? > Why not simply add a single line "depends on X86 || COMPILE_TEST"? It is because of the findings shared in [1]. Please let me know your thoughts on the findings. > > > > > > > You can drop the || COMPILE_TEST as well. > > > > I will drop this part of the change in the next version of the patch. > > Why drop that part? Isn't it good to have more compile test coverage? It is per the suggestion in the previous review comment. Ard, please share your thought here. I could add the || COMPILE_TEST. [1] Re: [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs https://lore.kernel.org/linux-efi/20190812150452.27983-1-ard.biesheuvel@xxxxxxxxxx/T/#mebff9ba48499808f59b33b2daef2d94e006296d8 -- With regards, Narendra K
