Hi Ard, Thank you for the review comments. On Wed, Oct 09, 2019 at 04:11:04PM +0200, Ard Biesheuvel wrote: > On Wed, 2 Oct 2019 at 21:44, <Narendra.K@xxxxxxxx> wrote: > > > > From: Narendra K <Narendra.K@xxxxxxxx> > > > > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user > > for input as it is a new kconfig option in kernel version 5.4. This patch > > modifies the kconfig option to ask the user for input only when CONFIG_X86 > > or CONFIG_COMPILE_TEST is set to y. > > > > The patch also makes EFI_RCI2_TABLE kconfig option depend on CONFIG_EFI. > > > > Signed-off-by: Narendra K <Narendra.K@xxxxxxxx> > > --- > > The patch is created on kernel version 5.4-rc1. > > > > Hi Ard, I have made following changes - > > > > - changed the prompt string from "EFI Runtime Configuration > > Interface Table Version 2 Support" to "EFI RCI Table Version 2 Support" > > as the string crossed 80 char limit. > > > > - added "depends on EFI" so that code builds only when CONFIG_EFI is > > set to y. > > > > - added 'default n' for ease of understanding though default is set to n. > > > > None of these changes are necessary, tbh. 'depends on EFI' is implied > by the placement of the option, and default n is indeed the default. I will drop the changes in the next version of the patch. > > > > drivers/firmware/efi/Kconfig | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig > > index 178ee8106828..6e4c46e8a954 100644 > > --- a/drivers/firmware/efi/Kconfig > > +++ b/drivers/firmware/efi/Kconfig > > @@ -181,7 +181,10 @@ config RESET_ATTACK_MITIGATION > > reboots. > > > > config EFI_RCI2_TABLE > > - bool "EFI Runtime Configuration Interface Table Version 2 Support" > > + bool > > + prompt "EFI RCI Table Version 2 Support" if X86 || COMPILE_TEST > > You can drop the || COMPILE_TEST as well. I will drop this part of the change in the next version of the patch. -- With regards, Narendra K
