On Thu, Aug 08, 2019 at 11:16:55AM +0300, Ard Biesheuvel wrote: > > On Wed, 7 Aug 2019 at 16:09, <Narendra.K@xxxxxxxx> wrote: > > On Thu, Jul 11, 2019 at 11:00:37PM +0000, Limonciello, Mario wrote: [...] > > Hi Ard, > > > > Does the version 1 of the patch look good ? Please share your thoughts. > > > > Thanks Narendra, > > The patch looks mostly fine. I have pushed it to my efi/next branch, Ard, thank you for the review comments and applying the patch. > and I will let you know if the autobuilders find any problems. Ok. > > One possible enhancement would be to defer the second memremap() call > until the first call to raw_table_read(), so the mapping only exists > if you are actually interested in the contents of the table. If you do > decide to make any followup changes, please send them as delta patches > against https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/log/?h=next Ok. I will work on the enhancement suggestion. Thank you for the suggestion. -- With regards, Narendra K
