Re: [PATCH V6 2/2] x86/efi: Add efi page fault handler to recover from page faults caused by the firmware

[Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>]

On 12 September 2018 at 20:56, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Tue, 11 Sep 2018, Sai Praneeth Prakhya wrote:
>> diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c
>> index b18b2d864c2c..7455277a3b65 100644
>> --- a/drivers/firmware/efi/runtime-wrappers.c
>> +++ b/drivers/firmware/efi/runtime-wrappers.c
>> @@ -61,6 +61,11 @@ struct efi_runtime_work efi_rts_work;
>>  ({                                                                   \
>>       efi_rts_work.status = EFI_ABORTED;                              \
>>                                                                       \
>> +     if (!efi_enabled(EFI_RUNTIME_SERVICES)) {                       \
>> +             pr_info("Aborting! EFI Runtime Services disabled\n");   \
>
> This probaby wants to be pr_info_ince().
>

I can fix that up when applying.

> Other than that:
>
>       Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Thanks! I will queue this up in efi/next