On 14 July 2018 at 12:06, Lukas Wunner <lukas@xxxxxxxxx> wrote:
> On Sat, Jul 14, 2018 at 12:12:38AM +0200, Ard Biesheuvel wrote:
>> On 13 July 2018 at 23:33, Lukas Wunner <lukas@xxxxxxxxx> wrote:
>> > On Sat, Jul 14, 2018 at 04:57:36AM +0800, kbuild test robot wrote:
>> >> vim +425 drivers/firmware/efi/libstub/efi-stub-helper.c
>> >>
>> >> 415
>> >> 416 static efi_status_t efi_open_volume(efi_system_table_t *sys_table_arg,
>> >> 417 efi_loaded_image_t *image,
>> >> 418 efi_file_handle_t **__fh)
>> >> 419 {
>> >> 420 efi_file_io_interface_t *io;
>> >> 421 efi_file_handle_t *fh;
>> >> 422 efi_guid_t fs_proto = EFI_FILE_SYSTEM_GUID;
>> >> 423 efi_status_t status;
>> >> 424 void *handle =
>> >> > 425 (void *)efi_table_attr(efi_loaded_image, device_handle, image);
>> > ^
>> > My apologies Ard, it seems I forgot an (unsigned long) cast here.
>> >
>> > Will give this a thorough review tomorrow morning with a fresh pair
>> > of eyeballs.
>>
>> No worries, I can fix it up.
>
> During a round of reviewing and testing this morning I found a checkpatch
> issue, there are eight spaces which should be replaced by a tab in line 429
> of drivers/firmware/efi/libstub/efi-stub-helper.c:
>
> diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c
> index 292576838708..e94975f4655b 100644
> --- a/drivers/firmware/efi/libstub/efi-stub-helper.c
> +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
> @@ -426,7 +426,7 @@ static efi_status_t efi_open_volume(efi_system_table_t *sys_table_arg,
> image);
>
> status = efi_call_early(handle_protocol, handle,
> - &fs_proto, (void **)&io);
> + &fs_proto, (void **)&io);
> if (status != EFI_SUCCESS) {
> efi_printk(sys_table_arg, "Failed to handle fs_proto\n");
> return status;
>
>
> Also, I noticed that for some reason, efi/urgent commit d7f2e972e702
> ("efi/x86: remove pointless call to PciIo->Attributes()") is currently
> squashed into the top-most commit on the efi/next branch. Not sure if
> intentional, but probably not?
>
No, thanks for spotting that.
I have fixed it up now, with the whitespace fix incorporated.
> Thanks & have a pleasant weekend.
>
> Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
