On 13 July 2018 at 00:22, Geoff Levand <geoff@xxxxxxxxxxxxx> wrote: > Hi Ard, > > On 07/04/2018 08:49 AM, Ard Biesheuvel wrote: >> efi/libstub: taken contents of LinuxExtraArgs UEFI variable into >> account > > To me this seems an overly complicated interface to the kernel, and > still doesn't in itself solve the problem at hand -- make the > generic distro kernel with APEI support run on m400 systems. > > As for me, I'd prefer something like my original patch. It fixes > that problem, it is simple and self contained, and is very clear > in what it does. Also, there is a limited life. When the time > comes an announcement is made to the mailing lists 'Linux-XYZ will > no longer support the m400 Moonshot'. Then, when the Linux-XYZ-rc1 > merge window opens a patch goes in that removes the > acpi_fixup_m400_quirks() routine. > Actually, that is a very good point. One of the issues I have with these quirks is that the burden is on the maintainers to keep them around forever, unless they can prove that it is no longer needed. This is not my call to make, but I would be much less averse to this being merged if we could agree upfront on an expiration time of, say, 2 years (or more?), after which it will be removed (unless anyone makes a very good case for why it needs to be retained). This should be mentioned in the kernel log as well when the quirk is triggered. I still think we should not be using DMI, though. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
