Re: [PATCH 1/6] efi/x86: prevent reentrant firmware calls in mixed mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13 July 2018 at 04:01, Prakhya, Sai Praneeth
<sai.praneeth.prakhya@xxxxxxxxx> wrote:
>> The UEFI spec does not permit runtime services to be called reentrantly, and so
>> it is up to the OS to provide proper locking around such calls.
>>
>> For the native case, this was fixed a long time ago, but for the mixed mode case,
>> no locking is done whatsoever. Note that the calls are made with preemption
>> and interrupts disabled, so only SMP configurations are affected by this issue.
>>
>> So add a spinlock and grab it when invoking a UEFI runtime service in mixed
>> mode. We will also need to provide non-blocking versions of SetVariable() and
>> QueryVariableInfo(), so add those as well.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>
> FWIW, this patch looks good to me.
>

Thanks Sai. I will take this as an acked-by


> Regards,
> Sai
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux