> On Mon, May 21, 2018 at 08:13:03PM -0700, Sai Praneeth Prakhya wrote: > > + /* \ > > + * queue_work() returns 0 if work was already on queue, \ > > + * _ideally_ this should never happen. \ > > + */ \ > > + if (queue_work(efi_rts_wq, &efi_rts_work.work)) > \ > > + flush_work(&efi_rts_work.work); > \ > > Since you're _always_ going to wait for it, it is _much_ cheaper to put a > completion in your actual work and wait for that. Sure! I will change it. I also noticed that flush_work() in turn calls wait_for_completion(). Will also wait for a couple of days before posting V4. Regards, Sai -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
