On 14 May 2018 at 08:58, Ingo Molnar <mingo@xxxxxxxxxx> wrote: > > * Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote: > >> On 14 May 2018 at 08:43, Ingo Molnar <mingo@xxxxxxxxxx> wrote: >> > >> > So I looked at arch/x86/boot/compressed/eboot.c to improve a printk message and >> > ended up with the cleanups below. >> > >> > Only build tested. >> > >> > Thanks, >> > >> > Ingo >> > >> > =================> >> > Subject: efi/x86: Clean up the eboot code >> > From: Ingo Molnar <mingo@xxxxxxxxxx> >> > Date: Mon May 14 08:33:40 CEST 2018 >> > >> > Various small cleanups: >> > >> > - Standardize printk messages: >> > >> > 'alloc' => 'allocate' >> > 'mem' => 'memory' >> > >> > also put variable names in printk messages between quotes. >> > >> > - Align mass-assignments vertically for better readability >> > >> > - Break multi-line function prototypes at the name where possible, >> > not in the middle of the parameter list >> > >> > - Use a newline before return statements consistently. >> > >> > - Use curly braces in a balanced fashion. >> > >> > - Remove stray newlines. >> > >> > No change in functionality. >> > >> > Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> >> > Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> >> > Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> >> > Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx> >> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx> >> > Cc: linux-efi@xxxxxxxxxxxxxxx >> > Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx> >> >> Thanks Ingo >> >> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > > Thanks - mind picking it up into your tree? I only did minimal testing and don't > want to interfere with your patch flow either. > Will do, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
