On 24 April 2018 at 17:15, Kim Phillips <kim.phillips@xxxxxxx> wrote: > On Tue, 24 Apr 2018 12:00:58 +0100 > Mark Rutland <mark.rutland@xxxxxxx> wrote: > >> When CONFIG_RANDOMIZE_TEXT_OFFSET is selected, TEXT_OFFSET is an >> arbitrary multiple of PAGE_SIZE in the interval [0, 2MB). >> >> The EFI stub doesn't accuont for this, and only handles the case where >> TEXT_OFFSET is multiple of EFI_KIMG_ALIGN. This can result in the kernel >> being loaded to an erroneous physical alignment. This has been observed >> to result in spurious stack overflow reports and failure to make use of >> the IRQ stacks, and theoretically could result in a number of other >> issues. >> >> We can OR in the low bits of TEXT_OFFSET to ensure that we have the >> necessary offset (and hence have the necessary alignment), so let's do >> that. >> >> Fixes: 6f26b3671184c36d ("arm64: kaslr: increase randomization granularity") >> Reported-by: Kim Phillips <kim.phillips@xxxxxxx> >> Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx> >> Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> >> Cc: linux-efi@xxxxxxxxxxxxxxx >> --- > > Tested-by: Kim Phillips <kim.phillips@xxxxxxx> > Thanks all Queued in efi/urgent. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html