On Tue, Apr 24, 2018 at 01:11:40PM +0200, Ard Biesheuvel wrote: > Hi Mark, > > On 24 April 2018 at 13:00, Mark Rutland <mark.rutland@xxxxxxx> wrote: > > When CONFIG_RANDOMIZE_TEXT_OFFSET is selected, TEXT_OFFSET is an > > arbitrary multiple of PAGE_SIZE in the interval [0, 2MB). > > > > The EFI stub doesn't accuont for this, and only handles the case where > > 'account' > > If you agree, I will add something here to clarify that the newly > chosen offset should retain the misalignment of TEXT_OFFSET relative > to EFI_KIMG_ALIGN, because it took me a while to figure that out. That makes sense to me. Sorry for the clumsy wording! > > Other than that, > > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > > I will queue this as a fix Great; thanks! Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html