* Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote: > From: Sai Praneeth <sai.praneeth.prakhya@xxxxxxxxx> > > Presently, only ARM uses mm_struct to manage efi page tables and efi > runtime region mappings. As this is the preferred approach, let's make > this data structure common across architectures. Specially, for x86, > using this data structure improves code maintainability and readability. > diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h > index 85f6ccb80b91..00f977ddd718 100644 > --- a/arch/x86/include/asm/efi.h > +++ b/arch/x86/include/asm/efi.h > @@ -2,10 +2,14 @@ > #ifndef _ASM_X86_EFI_H > #define _ASM_X86_EFI_H > > +#include <linux/sched/mm.h> > +#include <linux/sched/task.h> > + > #include <asm/fpu/api.h> > #include <asm/pgtable.h> > #include <asm/processor-flags.h> > #include <asm/tlb.h> > +#include <asm/mmu_context.h> > > /* > * We map the EFI regions needed for runtime services non-contiguously, > diff --git a/include/linux/efi.h b/include/linux/efi.h > index f5083aa72eae..f1b7d68ac460 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -966,6 +966,8 @@ extern struct efi { > unsigned long flags; > } efi; > > +extern struct mm_struct efi_mm; > + > static inline int > efi_guidcmp (efi_guid_t left, efi_guid_t right) > { Ugh, I can see three problems with this patch: 1) Why is the low level asm/efi.h header polluted with two of the biggest header files in existence, to add a type to _another_ header (efi.h)? 2) Why is <linux/sched/task.h> included if what is being relied on is mm_struct? 3) But even <linux/sched/mm.h> looks unnecessary in efi.h, a simple forward declaration of mm_struct would do ... The high level MM and sched headers should be added to the actual .c files that make use of them. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html