On 24 August 2017 at 10:12, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> Avoid effectively open-coding the function.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> drivers/firmware/efi/efi-bgrt.c | 22 +---------------------
> 1 file changed, 1 insertion(+), 21 deletions(-)
>
> --- 4.13-rc6-EFI.orig/drivers/firmware/efi/efi-bgrt.c
> +++ 4.13-rc6-EFI/drivers/firmware/efi/efi-bgrt.c
> @@ -27,26 +27,6 @@ struct bmp_header {
> u32 size;
> } __packed;
>
> -static bool efi_bgrt_addr_valid(u64 addr)
> -{
> - efi_memory_desc_t *md;
> -
> - for_each_efi_memory_desc(md) {
> - u64 size;
> - u64 end;
> -
> - if (md->type != EFI_BOOT_SERVICES_DATA)
> - continue;
> -
> - size = md->num_pages << EFI_PAGE_SHIFT;
> - end = md->phys_addr + size;
> - if (addr >= md->phys_addr && addr < end)
> - return true;
> - }
> -
> - return false;
> -}
> -
> void __init efi_bgrt_init(struct acpi_table_header *table)
> {
> void *image;
> @@ -85,7 +65,7 @@ void __init efi_bgrt_init(struct acpi_ta
> goto out;
> }
>
> - if (!efi_bgrt_addr_valid(bgrt->image_address)) {
> + if (efi_mem_type(bgrt->image_address) != EFI_BOOT_SERVICES_DATA) {
> pr_notice("Ignoring BGRT: invalid image address\n");
> goto out;
> }
>
>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
