Re: [PATCH v2] efi: arm: enable DMI/SMBIOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 01, 2017 at 10:52:13AM +0000, Ard Biesheuvel wrote:
> (add Russell to To: field)

Thanks.

> On 1 June 2017 at 10:45, Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> wrote:
> > Wire up the existing support for SMBIOS tables (aka DMI), by moving the
> > arm64 init code to drivers/firmware/efi/arm-runtime.c (which is shared
> > between ARM and arm64), and adding a asm/dmi.h header to ARM that defines
> > the mapping routines for the firmware tables.
> >
> > This allows userspace to access these tables to discover system information
> > exposed by the firmware. It also sets the hardware name used in crash
> > dumps, e.g.,
> >
> >   Unable to handle kernel NULL pointer dereference at virtual address 00000000
> >   pgd = ed3c0000
> >   [00000000] *pgd=bf1f3835
> >   Internal error: Oops: 817 [#1] SMP THUMB2
> >   Modules linked in:
> >   CPU: 0 PID: 759 Comm: bash Not tainted 4.10.0-09601-g0e8f38792120-dirty #112
> >   Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015
> >   ^^^
> >
> > NOTE: This does *NOT* enable or encourage the use of DMI quirks, i.e., the
> >       the practice of identifying the platform via DMI to decide whether
> >       certain workarounds for buggy hardware and/or firmware need to be
> >       enabled. This would require the DMI subsystem to be enabled much
> >       earlier than we do on ARM, which is non-trivial.

I think that needs to be documented somewhere else other than the commit
message, although I'm not sure where.

> > Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> > Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> 
> Russell, if you have no objections to this patch, may we have your ack
> please? I will take it via the EFI tree then.

Acked-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux