On 4 October 2016 at 22:30, Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 04 Oct, at 11:34:31AM, Ard Biesheuvel wrote: >> >> These relocations are harmless, since the debug ones are only >> interpreted by the debugger, and the ones generated by >> EXPORT_SYMBOL(sort) will never be referenced, since the symbols they >> contain are either renamed to __efistub_xxx (arm64), or they are not >> part of the kernel proper (arm) >> >> So both cases are false positives, but the diagnostic is important, >> and so breaking the build is appropriate for any other absolute >> relocation that may appear. >> >> The effect of the patch is not that the diagnostic is ignored, but >> that these relocations are not generated in the first place (-g0) or >> removed explicitly (ksymtab/krcrctab+sort) rather than via a wildcard. >> So other than not breaking the build, this patch should have no user >> observeable differences. > > Thanks Ard, sounds reasonable. Feel free to take this through > whichever tree you think is best. > > Reviewed-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> Thanks Matt. Arnd: could you take this on top of the patch that adds CONFIG_EFI to multi_v7_defconfig? That would minimize the breakage, I think. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
