On Sat, 2014-09-06 at 10:03 +0100, Matt Fleming wrote: > On Fri, 05 Sep, at 06:34:52PM, Jeff Kirsher wrote: > > From: Mark Rustad <mark.d.rustad@xxxxxxxxx> > > > > It is a really bad idea to declare variables or parameters that > > have the same name as common types. It is valid C, but it gets > > surprising if a macro expansion attempts to declare an inner > > local with that type. Change the local names to eliminate the > > hazard. > > Oops, good catch. Could you include a copy of the compiler shadow > warnings in the commit log? I'm guessing this bug is highlighted with > -Wshadow? How did you discover this problem? Mark was using W=2 to see the warning, so I will see if I can wade through the numerous warnings that get generated with W=2 for the specific warning. > > > Change s16 => ps16, s8 => ps8. > > Hmm... Instead, could you change it to str16 and str8? s8/s16 were > clearly misguided names in the first place, and it's not immediatealy > obvious to me that a 'ps16' would represent "pointer to 16-bit string". > Ok, I can re-spin the patch for Mark, that is if I can capture the original warning to add to his commit message. Otherwise, I will wait till Monday to have Mark re-spin the patch.
Attachment:
signature.asc
Description: This is a digitally signed message part
