On Fri, 05 Sep, at 06:34:52PM, Jeff Kirsher wrote: > From: Mark Rustad <mark.d.rustad@xxxxxxxxx> > > It is a really bad idea to declare variables or parameters that > have the same name as common types. It is valid C, but it gets > surprising if a macro expansion attempts to declare an inner > local with that type. Change the local names to eliminate the > hazard. Oops, good catch. Could you include a copy of the compiler shadow warnings in the commit log? I'm guessing this bug is highlighted with -Wshadow? How did you discover this problem? > Change s16 => ps16, s8 => ps8. Hmm... Instead, could you change it to str16 and str8? s8/s16 were clearly misguided names in the first place, and it's not immediatealy obvious to me that a 'ps16' would represent "pointer to 16-bit string". -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
