On Thu, Feb 13, 2014 at 3:26 AM, Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote: > On Wed, 05 Feb, at 05:03:57PM, Leif Lindholm wrote: >> From: Roy Franz <roy.franz@xxxxxxxxxx> >> >> Add the get_dram_base() function and efi_call_physN() macros >> that are shared by arm/arm64. >> >> Signed-off-by: Roy Franz <roy.franz@xxxxxxxxxx> >> Signed-off-by: Leif Lindholm <leif.lindholm@xxxxxxxxxx> >> --- >> drivers/firmware/efi/efi-stub-helper.c | 63 +++++++++++++++++++++++++------- >> 1 file changed, 50 insertions(+), 13 deletions(-) > > These changes should be in drivers/firmware/efi/arm-stub.c - > efi-stub-helper.c is not a dumping ground for random > architecture-specific code. Hi Matt, I will move those functions/macros to the arm-stub.c file. I agree that the macros should go there, as they are the arm specific versions and conflict with the x86 versions defined elsewhere. These were there before the arm-stub.c file was added and didn't get moved when it was. The get_dram_base() function is only used by arm/arm64, but there is nothing architecture specific about it, which is why I put it here to begin with. I don't feel strongly about this either way. Thanks, Roy > > -- > Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
