On Wed, Jan 29, 2014 at 04:23:49PM +0000, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@xxxxxxxxx>
>
> Now that we have EFI-specific page tables we need to lookup the pgd when
> dumping those page tables, rather than assuming that swapper_pgdir is
> the current pgdir.
>
> Remove the double underscore prefix, which is usually reserved for
> static functions.
>
> Cc: Borislav Petkov <bp@xxxxxxx>
> Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx>
Good, like the show_fault_oops() improvement.
Acked-by: Borislav Petkov <bp@xxxxxxx>
Btw, the commit title
"x86/mm/pageattr: Make __lookup_address_in_pgd() global"
doesn't give the patch its due credit. I'd say
"x86/mm/pageattr: Always dump the right page table in an oopsie"
or so.
> ---
> arch/x86/include/asm/pgtable_types.h | 2 ++
> arch/x86/mm/fault.c | 7 ++++++-
> arch/x86/mm/pageattr.c | 12 ++++++++----
> 3 files changed, 16 insertions(+), 5 deletions(-)
...
> @@ -365,7 +369,7 @@ static pte_t *__lookup_address_in_pgd(pgd_t *pgd, unsigned long address,
> */
> pte_t *lookup_address(unsigned long address, unsigned int *level)
> {
> - return __lookup_address_in_pgd(pgd_offset_k(address), address, level);
> + return lookup_address_in_pgd(pgd_offset_k(address), address, level);
Looks like I've introduced some whitespace booboo here:
ERROR: code indent should use tabs where possible
#57: FILE: arch/x86/mm/pageattr.c:372:
+ return lookup_address_in_pgd(pgd_offset_k(address), address, level);$
WARNING: please, no spaces at the start of a line
#57: FILE: arch/x86/mm/pageattr.c:372:
+ return lookup_address_in_pgd(pgd_offset_k(address), address, level);$
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
